search

KilianB / JImageHash

Perceptual image hashing library used to match similar images
MIT License
401 stars 81 forks source link

Rethink image matcher interface #18

Closed KilianB closed 5 years ago

KilianB commented 5 years ago

We deal with configured image matchers that have a float value associated when adding algorithms (Single Image Matcher , Database Image matcher) and matchers that do not have a preset in the same sense (cumulative image matcher and random forest matchers).

Maybe it's time to refactor the image matchers and introduce a new abstract class in between the interface and the implementations.

also move from float threshold to double precision, This will be yet another breaking change. Bump version to 3.0.0

16 should be resolved in the same patch if major version is bumped.

KilianB commented 5 years ago

Upgrade to double precision 65188a723a59414839e4fd68ae1116d7c28d38fe

KilianB commented 5 years ago

fixed with v 3.0.0