search

KillahPotatoes / KP-Liberation

The work on GreuhZbugs Liberation Mission for Arma 3 continues...
MIT License
264 stars 298 forks source link

New Secondary Objective 'Humanitarian Aid' #894

Open UselessFodder opened 2 years ago

UselessFodder commented 2 years ago
Q A
Bug fix? no
New feature? yes
Needs wipe? no

Description:

Content:

Successfully tested on:

UselessFodder commented 2 years ago

This is my first pull request, so I'm sorry if the formatting is off. Let me know what you guys think!

UselessFodder commented 2 years ago

Just doing a ping to ask if anyone has had to check this commit out? I think it would be a good inclusion to the base game.

MildlyInterested commented 2 years ago

@UselessFodder I will check them out as soon as I figure out how to get this PR to show up on my fork.

uniflare commented 2 years ago

Works great, nice job, integrated into our live fork. Never found the leader, and had to check the script for what exactly I had to do - maybe give details on what you need to do in the objective screen. Other than that, really nice, would be great to get some more side missions :).

UselessFodder commented 1 year ago

Thanks for catching that!

On Fri, Jun 17, 2022 at 11:04 AM ColinM9991 @.***> wrote:

@.**** requested changes on this pull request.

Just pulled this mission and found an issue with the English localisation. Other than this, nice work.

In Missionframework/stringtable.xml https://github.com/KillahPotatoes/KP-Liberation/pull/894#discussion_r900350211 :

  • Humanitarian Aid
  • Recherche et Sauvetage
  • Helikopterbergung
  • Búsqueda y rescate
  • Найти и Спасти
  • Cerca e Soccorri
  • 搜索与营救
  • 搜索與營救
  • Ara ve kurtar
  • Busca e Resgate
  • 수색 및 구출
  • Záchranná mise

  • <t size='1.3' color='#ffa000'>HUMANITARIAN AID</t><br/><br/><t size='1'>A nearby settlement has requested supplies, head out and deliver them to the highlighted settlement.</t><br/><br/><t size='1'>This will help win hearts and minds in the local region and ultimately help limit any locals engaging us in open and guerilla combat.</t><br/><br/><t size='1.15' color='#00a0ff'>Cost: 5<img image='\A3\Ui_f\data\GUI\Cfg\Ranks\general_gs.paa'/></t><br/><t size='1.15' color='#ffa000'>Reward: 5% increase in Civil Reputation.</t><br/><br/><t size='10'><img image='res\secondary\fob_obj.jpg/></t>

There's an apostrophe missing at the very end for the English localisation.

It should read image='res\secondary\fob_obj.jpg'/></t>

Currently it is image='res\secondary\fob_obj.jpg/></t>

— Reply to this email directly, view it on GitHub https://github.com/KillahPotatoes/KP-Liberation/pull/894#pullrequestreview-1010815825, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKO3XFDG4FJKMCVPQRCDXDVPSVZFANCNFSM5D7BHIWQ . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks! UselessFodder Twitch https://mail.google.com/mail/u/0/://twitch.tv/UselessFodder - YouTube https://youtube.com/UselessFodder Twitter https://twitter.com/UselessFodder - Instagram https://instagram.com/UselessFodder Discord http://discord.uselessfodder.com/ - Website http://uselessfodder.com/

NZF-JDWang commented 1 year ago

Just one little thing, you have KP_liberation_civ_supplies_impact in the config which allows you to set the cvi rep gain, however the stringtable is hard coded to 5%, so if you change KP_liberation_civ_supplies_impact to say 20, the sidemission will still say 5%

Otherwise this is a great idea for a side mission <3

UselessFodder commented 1 year ago

Thanks for the feedback! I'm not sure if there's a way to make that entry dynamic, but I will change it to just not say any percentage until I can figure it out

On Thu, Feb 23, 2023 at 7:26 PM NZF-JDWang @.***> wrote:

Just one little thing, you have KP_liberation_civ_supplies_impact in the config which allows you to set the cvi rep gain, however the stringtable is hard coded to 5%, so if you change KP_liberation_civ_supplies_impact to say 20, the sidemission will still say 5%

Otherwise this is a great idea for a side mission <3

— Reply to this email directly, view it on GitHub https://github.com/KillahPotatoes/KP-Liberation/pull/894#issuecomment-1442707553, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKO3XDJRWG7EZGWFN5QRW3WZAL6DANCNFSM5D7BHIWQ . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks! UselessFodder Twitch https://mail.google.com/mail/u/0/://twitch.tv/UselessFodder - YouTube https://youtube.com/UselessFodder Twitter https://twitter.com/UselessFodder - Instagram https://instagram.com/UselessFodder Discord http://discord.uselessfodder.com/ - Website http://uselessfodder.com/

ColinM9991 commented 1 year ago

Thanks for the feedback! I'm not sure if there's a way to make that entry dynamic, but I will change it to just not say any percentage until I can figure it out

You could use format by popping a %1 in the stringtable text.

UselessFodder commented 1 year ago

Oh, wow, that makes a lot of sense. I'll test that out when I get a chance.

On Fri, Feb 24, 2023 at 10:13 AM ColinM9991 @.***> wrote:

Thanks for the feedback! I'm not sure if there's a way to make that entry dynamic, but I will change it to just not say any percentage until I can figure it out … <#m-7046176233429153805> On Thu, Feb 23, 2023 at 7:26 PM NZF-JDWang @.> wrote: Just one little thing, you have KP_liberation_civ_supplies_impact in the config which allows you to set the cvi rep gain, however the stringtable is hard coded to 5%, so if you change KP_liberation_civ_supplies_impact to say 20, the sidemission will still say 5% Otherwise this is a great idea for a side mission <3 — Reply to this email directly, view it on GitHub <#894 (comment) https://github.com/KillahPotatoes/KP-Liberation/pull/894#issuecomment-1442707553>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKO3XDJRWG7EZGWFN5QRW3WZAL6DANCNFSM5D7BHIWQ https://github.com/notifications/unsubscribe-auth/ABKO3XDJRWG7EZGWFN5QRW3WZAL6DANCNFSM5D7BHIWQ . You are receiving this because you were mentioned.Message ID: @.> -- Thanks! UselessFodder Twitch https://mail.google.com/mail/u/0/://twitch.tv/UselessFodder - YouTube https://youtube.com/UselessFodder Twitter https://twitter.com/UselessFodder - Instagram https://instagram.com/UselessFodder Discord http://discord.uselessfodder.com/ - Website http://uselessfodder.com/

You could use format https://community.bistudio.com/wiki/format by popping a %1 in the stringtable text.

— Reply to this email directly, view it on GitHub https://github.com/KillahPotatoes/KP-Liberation/pull/894#issuecomment-1444059232, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKO3XDFPQ5CR4AIYCCOULTWZDT43ANCNFSM5D7BHIWQ . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks! UselessFodder Twitch https://mail.google.com/mail/u/0/://twitch.tv/UselessFodder - YouTube https://youtube.com/UselessFodder Twitter https://twitter.com/UselessFodder - Instagram https://instagram.com/UselessFodder Discord http://discord.uselessfodder.com/ - Website http://uselessfodder.com/

UselessFodder commented 1 year ago

Thanks for the feedback! I'm not sure if there's a way to make that entry dynamic, but I will change it to just not say any percentage until I can figure it out

You could use format by popping a %1 in the stringtable text.

So, I spent some time looking at this recently and I'm not sure how to utilize format in this situation as the text goes through a localization and a parseText to display the values on the secondary mission UI. Here is the route:

This code calls for the _briefings text:

// In: \scripts\client\ui\secondary_ui.sqf Start Line 27

_briefings = [
    "STR_SECONDARY_BRIEFING0",
    "STR_SECONDARY_BRIEFING1",
    "STR_SECONDARY_BRIEFING2",
    "STR_SECONDARY_BRIEFING3"
];

....

while { dialog && alive player && dostartsecondary == 0 } do {

    if ( _oldchoice != lbCurSel 101 ) then {
        _oldchoice = lbCurSel 101;
        ctrlSetText [ 106, _images select _oldchoice ];
        ((findDisplay 6842) displayCtrl (102)) ctrlSetStructuredText parseText localize (_briefings select _oldchoice);
    };

This pulls the text from stringtable.xml here:

// In: \stringtable.xml Start Line 7377
<Key ID="STR_SECONDARY_BRIEFING3">
            <Original>&lt;t size='1.3' color='#ffa000'&gt;HUMANITARIAN AID&lt;/t&gt;&lt;br/&gt;&lt;br/&gt;&lt;t size='1'&gt;A nearby settlement has requested supplies, head out and deliver them to the highlighted settlement.&lt;/t&gt;&lt;br/&gt;&lt;br/&gt;&lt;t size='1'&gt;This will help win hearts and minds in the local region and ultimately help limit any locals engaging us in open and guerilla combat.&lt;/t&gt;&lt;br/&gt;&lt;br/&gt;&lt;t size='1.15' color='#00a0ff'&gt;Cost: 5&lt;img image='\A3\Ui_f\data\GUI\Cfg\Ranks\general_gs.paa'/&gt;&lt;/t&gt;&lt;br/&gt;&lt;t size='1.15' color='#ffa000'&gt;Reward: 5% increase in Civil Reputation.&lt;/t&gt;&lt;br/&gt;&lt;br/&gt;&lt;t size='10'&gt;&lt;img image='res\secondary\fob_obj.jpg'/&gt;&lt;/t&gt;</Original>
            <French>&lt;t size='1.3' color='#ffa000'&gt;RECHERCHE ET SAUVETAGE&lt;/t&gt;&lt;br/&gt;&lt;br/&gt;&lt;t size='1'&gt;Nous avons perdu le contact avec un helicoptère de reconnaissance en mission derrière les lignes ennemies. Il a probablement été abattu par les forces hostiles.&lt;/t&gt;&lt;br/&gt;&lt;br/&gt;&lt;t size='1'&gt;L'hélicopter a pu finir sa course dans une large zone autour de sa dernière position connue. Votre mission est de retrouver l'équipage et sa précieuse intel. Les forces hostiles les auront peut-être déjà retrouvés, votre action doit donc être rapide et décisive.&lt;/t&gt;&lt;br/&gt;&lt;br/&gt;&lt;t size='1.15' color='#00a0ff'&gt;Cout: 8&lt;img image='\A3\Ui_f\data\GUI\Cfg\Ranks\general_gs.paa'/&gt;&lt;/t&gt;&lt;br/&gt;&lt;t size='1.15' color='#ffa000'&gt;Récompense: 20 points d'intel (10 pour chaque équipage vivant).&lt;/t&gt;&lt;br/&gt;&lt;br/&gt;&lt;t size='10'&gt;&lt;img image='res\secondary\fob_obj.jpg'/&gt;&lt;/t&gt;</French>
            <German>......

This is the same format as the original secondary mission such as FOB_Hunt:

In: \stringtable.xml start line 3570
 ID="STR_SECONDARY_BRIEFING0">
            <Original>&lt;t size='1.3' color='#ffa000'&gt;FOB HUNTING&lt;/t&gt;&lt;br/&gt;&lt;br/&gt;&lt;t size='1'&gt;OPFOR forces use an array of small logistic bases situated behind the front lines. Destroying those assets would greatly disrupt the OPFOR supply lines and impair their capacity to react to our actions.&lt;/t&gt;&lt;br/&gt;&lt;br/&gt;&lt;t size='1'&gt;Your mission is to destroy all supply assets (trucks, containers) at the objective by any means at your disposal. Unfortunately our intelligence is not able to provide you with a precise position for the base, you will have to locate the objective in the red zone on your map.&lt;/t&gt;&lt;br/&gt;&lt;br/&gt;&lt;t size='1.15' color='#00a0ff'&gt;Cost: 15&lt;img image='\A3\Ui_f\data\GUI\Cfg\Ranks\general_gs.paa'/&gt;&lt;/t&gt;&lt;br/&gt;&lt;t size='1.15' color='#ffa000'&gt;**Reward: OPFOR alert level reduced by 40%**&lt;/t&gt;&lt;br/&gt;&lt;br/&gt;&lt;t size='10'&gt;&lt;img image='res\secondary\fob_obj.jpg'/&gt;&lt;/t&gt;</Original>

I can probably change the Secondary UI display for all of the missions to be in formatted text and pull the configuration values for each mission, but for now I think I am going to say that's a much bigger change than a simple secondary mission addition and leave the text to be the same format as the rest of the default missions. @ColinM9991 @NZF-JDWang

mevoyairyendo commented 3 weeks ago

How can I download it?