KilledByAPixel / LittleJS

LittleJS is a fast HTML5 game engine with many features and no dependencies. 🚂 Choo-Choo!
MIT License
3.19k stars 160 forks source link

[ NPM ] Last build 1.7.11 failing #68

Closed tperraut closed 8 months ago

tperraut commented 8 months ago

Hey, I was trying to make some little things with littlejs engine yesterday as I will start the Global Game Jam tonight and seems that the last version 1.7.11 uploaded on NPM has building issues :

Error: Process exited with code 1
✘ [ERROR] "drawTileScreenSpace" is not declared in this file

    node_modules/littlejsengine/build/littlejs.esm.js:5130:1:
      5130 │   drawTileScreenSpace,
           ╵   ~~~~~~~~~~~~~~~~~~~

✘ [ERROR] "drawRectScreenSpace" is not declared in this file

    node_modules/littlejsengine/build/littlejs.esm.js:5131:1:
      5131 │   drawRectScreenSpace,
           ╵   ~~~~~~~~~~~~~~~~~~~

Error: Build failed with 2 errors:
node_modules/littlejsengine/build/littlejs.esm.js:5130:1: ERROR: "drawTileScreenSpace" is not declared in this file
node_modules/littlejsengine/build/littlejs.esm.js:5131:1: ERROR: "drawRectScreenSpace" is not declared in this file
    at _0x345efc._evaluate (https://httpspkgsizedev-jeqp.w-corp.staticblitz.com/blitz.6854296d.js:352:378687)
    at async ModuleJob.run (https://httpspkgsizedev-jeqp.w-corp.staticblitz.com/blitz.6854296d.js:181:2372) {
  errors: [
    {
      detail: undefined,
      id: '',
      location: [Object],
      notes: [],
      pluginName: '',
      text: '"drawTileScreenSpace" is not declared in this file'
    },
    {
      detail: undefined,
      id: '',
      location: [Object],
      notes: [],
      pluginName: '',
      text: '"drawRectScreenSpace" is not declared in this file'
    }
  ],
  warnings: []
}

What's weird is that I don't see any 1.7.11 version or tag on github releases.

Last but not least, thank you for your work, what you do is awesome !

KilledByAPixel commented 8 months ago

Sorry about that, I pushed out 1.7.12 and should be all good now!

It was failing because i removed those functions, now just a param passed to other draw functions, but forgot to remove from the exports.