KilleenCode / brancato

A cross-platform omnibar to to easily run workflows, built in Rust 🦀
MIT License
5 stars 2 forks source link

Signing for Mac & PR builds #57

Closed SeanKilleen closed 2 years ago

SeanKilleen commented 2 years ago

Resolves #50 (I think/hope)

Per https://tauri.studio/docs/distribution/sign-macos.

On My Local (Windows)

In this PR

ℹ️ Note that in the Tauri docs example here, it assumes only a macos build. It's possible that adding these variables in all matrixed builds may screw things up at first and we may need to find a way to wrap them in an if statement or two separate build steps based on matrix (or Tauri may be smart enough to pick that up.)

SeanKilleen commented 2 years ago

@RyKilleen do you want me to also set up PR builds as part of this? I'd hate to merge it and find out it screws things up.

https://github.com/tauri-apps/tauri-action#testing-the-build

RyKilleen commented 2 years ago

Always a great practice, thanks for setting that up!

RyKilleen commented 2 years ago

Regarding your comment around if statements, the matrix.platform should give us whatever we need to sign on Mac only the way we do for Windows

SeanKilleen commented 2 years ago

Figured out an issue. Tauri doesn't have its env variable aligned with its secret name in one case. I'll PR their docs again after I verify the fix.

SeanKilleen commented 2 years ago

OK I can't spend more time on this at the moment but I think the issue is that I created a Distribution certificate rather than a developer ID certificate. I should be able to remedy that when I free up and then I think this process should work.

SeanKilleen commented 2 years ago

Looks like we're good to go now! @RyKilleen, merge when ready.

RyKilleen commented 2 years ago

I'll bump versions and rebase the branch if you're alright with that

SeanKilleen commented 2 years ago

@RyKilleen do it! 👍