search

KillenCraft / Nelliks-HighDef-GUIs

:art: A minecraft Resource Pack that replaces GUI windows with high quality versions.
https://minecraft.curseforge.com/projects/nelliks-highdef-guis
Creative Commons Attribution Share Alike 4.0 International
4 stars 6 forks source link

Started adding huge mod support #2

Closed TimGoll closed 6 years ago

TimGoll commented 6 years ago

Description

started adding huge mod support. Not yet finished, many mods to go. But maybe you want to add all these new textures. Focused my work on GUIs, not on icons. If you want to rework them, feel free ... psds included

ScottKillen commented 6 years ago

@TimGoll Please sign the CLA to allow me to incorporate these changes.

TimGoll commented 6 years ago

done

ScottKillen commented 6 years ago

Thanks!

ScottKillen commented 6 years ago

@TimGoll Please add your psd files for the work you did on JEI.

Just add another commit.

TimGoll commented 6 years ago

I have just copied some stuff out of your GUIs, there's no PSD file.

ScottKillen commented 6 years ago

OK. Thanks.

ScottKillen commented 6 years ago

The packs are not building correctly. This may take a bit to get released.

ScottKillen commented 6 years ago

Working on these...but you only did 1.12 versions and all of the files are not in the right place for the pack to build properly.

TimGoll commented 6 years ago

Sorry, but I don't know how to make it the way you need it. For me it works this way. Just drop all these Folders into the ZIP. And Done.

ScottKillen commented 6 years ago

I'm working on fixing it...but following these instructions no longer works.

ScottKillen commented 6 years ago

I am rejecting this because this breaks the build and does not follow the contribution conventions (eg. not all psd files are included and none are in the right places).

Furthermore, only support for MC 1.12 versions of the mods are included. When adding support for a mod, support needs to be added for each version of Minecraft, beginning at 1.71.0 and following.

TimGoll commented 6 years ago

Okay, if you don't want it, don't use it

TimGoll commented 6 years ago

Am I allowed to publish my own add on on curseforge?

ScottKillen commented 6 years ago

@TimGoll I do want it, but I don't have the time to fix it.

You are allowed to publish your own add on. If you derive from the content here, you must follow the terms of the license.

TimGoll commented 6 years ago

Okay, I'll look into it. It's basically okay, if I publish a RP without the stuff you have done and mention, that your pack is needed, too.

ScottKillen commented 6 years ago

Yes! If you send me a link, I will link to your pack also.