KillerBOSS2019 / SoundcoreDesktop

a way to communicate with Anker Soundcore Life headphones
GNU General Public License v3.0
98 stars 16 forks source link

Cleaner README.md #3

Closed JordanViknar closed 2 years ago

JordanViknar commented 2 years ago

The README.md was messy, so I simply cleaned it and made it more readable.

(I intend to try your application later, and check if it also works on Linux, since I don't use Windows. If it doesn't, I might make another fork followed by a Pull Request.)

JordanViknar commented 2 years ago

This is a draft because I want to take some time later to confirm I did not make any mistake before merging.

KillerBOSS2019 commented 2 years ago

Alright just so you know I am working on a rework. because as right now the GUI when you click a button it will connect to headphone and then disconnect I wanted to make it so the connection always open until the APP is closed

KillerBOSS2019 commented 2 years ago

And also add a EQ settings :D image

JordanViknar commented 2 years ago

I think the README.md is close to done. I'll have to check one last time for good when I can, and then I'll set this pull request as "Ready for review".

JordanViknar commented 2 years ago

The only thing left to do is add a note that you need Python installed (obviously) and also Tkinter installed (slightly less obvious). As for the application, I didn't manage to start it on my system, but I was using the Wayland windowing system, and I suspect that Tkinter doesn't support it well (yet ?). I'll try again with X11/Xorg's windowing system later.

JordanViknar commented 2 years ago

The API also fully works under Linux. The application is incompatible with Wayland (even with XWayland in my case, which is unexpected), but does work properly under X11/Xorg, which is the default for most Desktop Environments anyways.

JordanViknar commented 2 years ago

Took me more time than it should have, but I've opened the Pull Request.

KillerBOSS2019 commented 2 years ago

Thank you! I've also update the API and reworked the Desktop app