Closed an-bss closed 4 months ago
The call QuillModule.forRoot({ sanitize: true }) has no effect on QuillEditorComponent instances.
QuillModule.forRoot({ sanitize: true })
It is used here: https://github.com/KillerCodeMonkey/ngx-quill/blob/2ec7418f1ca7c7201b444a92483dd6d996f2b698/projects/ngx-quill/src/lib/quill-editor.component.ts#L199 The setting from the config in the service is only being used, if this.sanitize() is neither true nor false. this.sanitize() is an input and defined here: https://github.com/KillerCodeMonkey/ngx-quill/blob/2ec7418f1ca7c7201b444a92483dd6d996f2b698/projects/ngx-quill/src/lib/quill-editor.component.ts#L96
this.sanitize()
The input is initialized with false. Therefore the value from this.service.config.sanitize is never used. My proposal is to change the initial value of the input to undefined. Any thoughts on that?
this.service.config.sanitize
undefined
released in v26.0.5
The call
QuillModule.forRoot({ sanitize: true })
has no effect on QuillEditorComponent instances.It is used here: https://github.com/KillerCodeMonkey/ngx-quill/blob/2ec7418f1ca7c7201b444a92483dd6d996f2b698/projects/ngx-quill/src/lib/quill-editor.component.ts#L199 The setting from the config in the service is only being used, if
this.sanitize()
is neither true nor false.this.sanitize()
is an input and defined here: https://github.com/KillerCodeMonkey/ngx-quill/blob/2ec7418f1ca7c7201b444a92483dd6d996f2b698/projects/ngx-quill/src/lib/quill-editor.component.ts#L96The input is initialized with false. Therefore the value from
this.service.config.sanitize
is never used. My proposal is to change the initial value of the input toundefined
. Any thoughts on that?