search

KillerCodeMonkey / ngx-quill

Angular (>=2) components for the Quill Rich Text Editor
MIT License
1.79k stars 264 forks source link

Error TS2614 when linting `ngx-quill@10.0.1` #896

Closed KeithGillette closed 4 years ago

KeithGillette commented 4 years ago

After updating to ngx-quill@10.0.1, I get the following linting error:

ERROR in node_modules/ngx-quill/lib/quill-editor.component.d.ts:3:21 - error TS2614: Module '"../../@types/quill"' has no exported member 'Delta'. Did you mean to use 'import Delta from "../../@types/quill"' instead?

3 import QuillType, { Delta } from 'quill';
KillerCodeMonkey commented 4 years ago

install @types/quill 1.3.10 as dev dependency

KeithGillette commented 4 years ago

We are already using "@types/quill": "2.0.3". Are you suggesting we need to downgrade?

KillerCodeMonkey commented 4 years ago

in general the @typings should match the real package version.

so @types/quill 2.0.3 are for quilljs 2.x latest version for quilljs is 1.3.10 ;-)

Since i only want to support stable quill version i do not support quilljs 2 dev versions, yet.

i think quilljs 1.3.7 and @types/quill 1.3.10 should fix your issue.

KeithGillette commented 4 years ago

Oops, got it. Thanks so much for your fast, helpful replies—and for maintaining this library!

revzo commented 3 years ago

általában meg @typingskell egyeznie a valódi csomag verzióval.

így a @types/quill2.0.3 a quilljs-re vonatkozik. 2.x a quilljs legújabb verziója az 1.3.10 ;-)

Mivel csak a stabil quill verziót szeretném támogatni, még nem támogatom a quilljs 2 dev verzióit.

szerintem a quilljs 1.3.7 és a @ type / quill 1.3.10 megoldja a problémát.

Thansk for the solution! :)

sahilkumarsahoo commented 2 years ago

it work properly in angular12 "@types/quill": "^1.3.10", "ngx-quill": "^15.0.0", "quill": "^1.3.7",

KillerCodeMonkey commented 2 years ago

Why you are linting node modules?

And since v15 you should use angular v13

sahil kumar sahoo @.***> schrieb am So., 5. Dez. 2021, 07:52:

it work properly in angular12 @.**/quill": "^1.3.10", "ngx-quill": "^15.0.0", "quill": "^1.3.7",

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/KillerCodeMonkey/ngx-quill/issues/896#issuecomment-986177106, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARI4YADF2OEK4CN4WKPUITUPMD2XANCNFSM4M42HCEA .