search

KillerDJLang / Raid-Overhaul

3 stars 2 forks source link

Bartering ReqForms for items consumes entire stack #15

Closed KJB88 closed 4 months ago

KJB88 commented 5 months ago

SPT Version: 3.8.0 BepInEx Version: 5.4.22.0 Raid Overhaul Version: 2.2.0 (note that everything is disabled except the Requisitions Office and Legion).

Description When bartering n amount of RequisitionForms for an item via the Requisitions Office trader, the trader will consume the whole stack of RequisitionForms even if the stack exceeds n.

Repro Steps

  1. Hold within your stash an amount of RequisitionForms that exceeds the barter cost of any item sold by the Requisitions Office that costs RequisitionForms .
  2. Proceed to barter successfully for the item, consuming your RequsitionForms.
  3. Notice that the entire stack of RequisitionForms has been consumed.

Other Mods

KJB88 commented 5 months ago

This also happens when bartering for anything costing RequisitionSlips. The entire stack will be consumed.

KJB88 commented 4 months ago

Further to this issue. Having two stacks of either item, one being less than the required amount and the other being equal or above the required amount, the trader will take either stack. Meaning that an exploit exists where you can split a stack into the cost of the item in slips/forms, and a stack of 1. The trader will take the stack of one and leave the larger stack. This means you have purchased an item costing slips/forms but only paid a single form/slip.

KillerDJLang commented 4 months ago

Are you able to reproduce this with only Raid Overhaul? It isn't consuming the entire stack of either currency during purchase for me and that's on both Spt and Fika with my standard modlist.

KJB88 commented 4 months ago

It does not happen with just SPT 3.8.3 and latest Raid Overhaul. Seems to be a mod conflict.

Thanks for looking into this and apologies for wasting your time. Keep up the amazing work!