search

Killface1980 / StorageSearch

Rimworld - Storage Search - Simple UI mod
Other
11 stars 7 forks source link

Separate search strings #6

Closed Killface1980 closed 6 years ago

Killface1980 commented 7 years ago

I noticed that it's a little awkward when searching for e.g. steel in the storage, and when editing outfits finding an empty window.

What do you think?

DoctorVanGogh commented 7 years ago

Yeah, it's on my 'minor issues to look at' list.

Do we want to clear search strings between searches? Keep different search strings for each type of search? Or only special case Outfits? Personally I'd vote for the 'three different search strings' version.

Killface1980 commented 7 years ago

From my experience / preferences as a player, I suggest:

Another idea: with Vegetable Garden and Apparello, the Plant Grow list becomes rather full, respectively the tailor stuff or any other float menu bill. Fluffy's working on a production menu as replacement for the Production tab in his Colony Manager. Maybe have a look at the plant menu first and see what's possible?

DoctorVanGogh commented 7 years ago

Phew - filters on float menus sound "interesting".... No idea if those could be done. (I'd expect "weird" focus auto-close behavior with menus, no idea if we could anchor an input control in there).

Regarding Fluffy's production thing: That was one of the reasons why I'm favoring the 'external assembly' thing. It would have been another place to slap in search boxes ;)

Killface1980 commented 7 years ago

I can help out with the float menu thing. A view of the produceable things sorted by body part was actually working in the Outfitter mod, till some recipes from other mods had null fields. I have some experience with float menu options and can take a look at it. I'm currently very busy with Tools For Haul …

DoctorVanGogh commented 7 years ago

Funny - my only experience with float menus is limited.

Oh well, I went ahead and chopped the mod into two assemblies. I think we can close #7 then :grin:

Take a look at my library branch.

And yeah, I snuck that RimworldInstall.props back in there - if you can't get it to work by editing this path I'll chop it back out before merging. It's just two projects now, each with two assembly references that will create noise on commits from different machines.

Moved StorageSearch into it's own project directory, added a SearchFilterproject aside it. Moved some options & strings around. The Idea is to bundle

together with some kind of HOWTO.md into a zip and publish that as an embeddable DEV release here on github.

On a somewhat different topic: Have you ever taken a look at VisualStudio Code for general mod editing (Still need VS201x itself for assembly builds)?

image

I find it a lot more accessible than reintegrating hardlinks for language defs or preview/about stuff down to assembly projects.

DoctorVanGogh commented 7 years ago

Did some nice UI improvements while cleaning this up: image image image

With the search box inside the filter (and not one extra pixel used :grin:) we need no longer care where the filter is used, and if there are possibly overlapping controls (like in the outfit dialog).

I like this. Your take? 👍 ? 👎 ? ❓ ?

Killface1980 commented 7 years ago

Gorgeous! Maybe add a little space between the buttons, and is it possible to re-add the description? Just looks a little bit naked. Great work!

DoctorVanGogh commented 7 years ago

I can easily do more spacing - and the description(s) are already in there (moved to tooltip, since embedding them inline would have required significantly enlarging the buttons).

image

At a later date we can maybe use other icons (was thinking something like Hugs' 'Allow all' icon). image But maybe with just two checkmarks/crosses below each other - possibly monochromatic.... Then again - it's only 24x24 pixels of real estate...

Maybe later - I am way slower at drawing icons than writing code. This looks good enough for right now.

DingoDjango commented 7 years ago

You should Rect.ContractedBy(1f) or another float for those buttons/filter. Either that or reposition the rects so that the edges don't overlap with the list rect's edge line.

DoctorVanGogh commented 7 years ago

They are and they don't - but I'm assuming you'd vote for some padding in there (Fun fact: vanilla has no such padding :grin:)

DingoDjango commented 7 years ago

It looks miles better when the visible edges don't overlap. If your definition of "not overlapping" is that the text filter's visible edge line is a pixel or two below the list rect's line it does not make the eye like it better...

Killface1980 commented 7 years ago

yes, icons need more room to breath