search

KillianLucas / ooba

Run language models on consumer hardware.
GNU Affero General Public License v3.0
26 stars 6 forks source link

Fixes restart every second message #8

Closed Notnaton closed 7 months ago

Notnaton commented 1 year ago

This hack makes Ooba restart every second prompt. I removed the else statement to stop it from restarting all the time.

If this is supposed to ensure the model is running it's better to check if the port is open and restart it if it is closed.

Notnaton commented 1 year ago

Need some feedback on this, I don't understand the problem the hack fixes @KillianLucas

KillianLucas commented 1 year ago

If you've tested it and it works, I'm happy to merge it. It did break on second use for me and required a restart, but that might have been another issue that has since resolved.

Does it work for you if we have it not restart all the time?

Notnaton commented 1 year ago

I haven't tested the latest addition properly. It's late now and will do it tomorrow. I'm unsure if we need it at all.

Notnaton commented 1 year ago

During first install: bilde Connecting to server can timeout, changed sleep(1.5) to sleep(5). from 75s to 250s. This is due to the --update in update_cmd, I believe. Should only be a problem if the person has slow internet. Once updated, they can simply re run interpreter and it works.

@KillianLucas Tested

Notnaton commented 1 year ago

@KillianLucas I have tested it on two other windows systems using this: pip install git+https://github.com/Notnaton/ooba.git@windows. it contains all 3 patches I made.