KillingSpark / rustysd

A service manager that is able to run "traditional" systemd services, written in rust
MIT License
495 stars 15 forks source link

Add continous integration #1

Closed EdorianDark closed 4 years ago

EdorianDark commented 4 years ago

Setting up a continuous integration helps to see build or test failures early

KillingSpark commented 4 years ago

Thanks for the CI stuff. I'd like to keep the json config. Can you make a new PR without the f92e4ee commit?

EdorianDark commented 4 years ago

Why do you prefer Json over Ini or Toml? For me it seems that Json is manly useful as a data transformation format, but not intended for humans as features as comments are missing. SInce this project has to parse Ini files, it would make sense to use Ini hiere.

KillingSpark commented 4 years ago

I like it over ini because it explicitly has support for simple types like numbers/strings/booleans.

I never used toml before, i would be open to have that as a secondary config format