search

KillingSpark / rustysd

A service manager that is able to run "traditional" systemd services, written in rust
MIT License
495 stars 15 forks source link

Small refactors #7

Closed leshow closed 4 years ago

leshow commented 4 years ago

I just stumbled across your project and was looking through the code, I made some small refactors. Mostly removing clones, adding derives (so when you eventually add proper error handling it should be a bit easier). For the unit types, it's worthwhile to implement Copy, and where it's converted to a string use ToString. There was also one Mutex<bool> I changed to an AtomicBool.

Fun project you've got, good luck!

KillingSpark commented 4 years ago

Hey thanks for the PR! Will look trough these and merge what still applies. I went trough some refactoring myself today. In any case I always appreciate support :)