Fix vertex strides issues and a device memory leak

KilnGraphics / Blaze4D

Minecraft but with Vulkan.

GNU Lesser General Public License v3.0

270 stars 12 forks source link

Fix vertex strides issues and a device memory leak #31

Closed CodingRays closed 3 years ago

CodingRays commented 3 years ago

So i fixed the vertex strides issues by rebinding the main buffer before each draw call with a byte offset. It is an ugly hack but honestly im not sure if it is possible to do this cleanly without some refractors.

Also the RenderSystemMixin required the remap = false otherwise it would not build for me.

CodingRays commented 3 years ago

The vertex stride issue has now been fixed without needing to rebind the buffer.

CodingRays commented 3 years ago

Also added a small patch that frees the vertex buffers when they get overwritten

burgerindividual commented 3 years ago

looks good, gonna merge to big_nuts and merge big_nuts to master