search

KilowattApp / open-ev-data

Open Dataset of Electric Vehicle specs. Maintained by Kilowatt, the electric charging timer app for iOS.
Other
10 stars 5 forks source link

Missing cars #11

Closed FilipeOS closed 2 weeks ago

FilipeOS commented 2 months ago

Hi,

Can this cars be added? And maybe others?

FilipeOS commented 2 months ago
FilipeOS commented 2 months ago
tijs commented 2 weeks ago

@FilipeOS if you have the chance it would be much appreciated if you can add these models, you can base your updated details on existing data from manufacturers, the web etc. I'm working on making adding data easier but for now you'd have to update the JSON file and then validate it's ok with the new tests.

tijs commented 2 weeks ago

I've added a new way to more easily add data yourself using the add_vehicle.rb script. Please checkout the README and see if this might help you out. I've added an example model variant addition in the #14 pull request to give you an idea of what that looks like.

FilipeOS commented 2 weeks ago

That new way is only for that brands? Or you are doing a generic curve? Because I do that too. Can you shared the percentage and values?

tijs commented 2 weeks ago

no you can add for any existing brand or model, or add new brands and models, with the CLI. And yes If you do not know the curve the script will guesstimate a generic curve for you based on the Max DC charge value.