search

KiltMC / Kilt

A Fabric mod that brings Forge mods into the Fabric ecosystem.
GNU Lesser General Public License v2.1
93 stars 6 forks source link

FerriteCore crashes on startup #6

Open BluSpring opened 1 year ago

BluSpring commented 1 year ago

When loading into the game with FerriteCore, the game will crash with the error:

java.lang.ClassCastException: class net.minecraft.client.resources.model.ModelResourceLocation cannot be cast to class malte0811.ferritecore.mixin.mrl.ResourceLocationAccess (net.minecraft.client.resources.model.ModelResourceLocation and malte0811.ferritecore.mixin.mrl.ResourceLocationAccess are in unnamed module of loader net.fabricmc.loader.impl.launch.knot.KnotClassLoader @498d318c)

Currently, the only way to fix this is by going into config/ferritecore.mixin.properties and setting modelResourceLocations = true to modelResourceLocations = false.

BluSpring commented 7 months ago

This issue is currently being mitigated by disabling the ResourceLocation mixin that is created by FerriteCore. However, this issue seems to be largely a mixin issue that is also caused by Kilt mixing into ResourceLocation.

Maybe we can remove this mixin and instead rely on Porting Lib's compareNamespaced mixin.

BluSpring commented 6 months ago

We're currently working around this issue by simply disabling the ModelResourceLocation mixin in FerriteCore via MixinSquared (see: 483c080384312e2700a84429733b1cfe06c6c377)