Kilvoctu / aiyabot

A neat Discord bot for AUTOMATIC1111's Web UI
GNU General Public License v2.0
305 stars 79 forks source link

Live preview #234

Closed sebaxakerhtc closed 4 months ago

sebaxakerhtc commented 5 months ago

Hi! As I remember, about a year ago we talked about adding live preview, but you said you will create it by yourself another way. There's still no live preview as I see, that's why I create this PR. In the future, when you'll do your own code for it - you can just revert this PR ;)

JustGuyThatGuy commented 5 months ago

Cool feature, I noticed core/stablecog.py lines 404-407 contains non-English text and sure it gets updated when the gen starts, but it would probably be worth updating to something like:


f'**Prompt**: `{queue_object.prompt}`\n**Progress**: Initialising...'
f'\n0/{queue_object.steps} iterations, 0.00 it/s'
f'\n**ETA**: Initialising...'))
JustGuyThatGuy commented 5 months ago

After playing about with this a bit more, I've also noticed it's causing a bunch of Something goes wrong... 404 Not Found (error code: 10008): Unknown Message... not sure if it's somehow trying to interact with messages after they've been deleted perhaps?

sebaxakerhtc commented 5 months ago

I noticed core/stablecog.py lines 404-407 contains non-English text

Thank you. Edited

sebaxakerhtc commented 5 months ago

I've also noticed it's causing a bunch of Something goes wrong... 404 Not Found (error code: 10008): Unknown Message...

Can you provide the log (if you see it in console) ? Because I use it every day last year and didn't see it. изображение

JustGuyThatGuy commented 5 months ago

Unfortunately that's all that's shown in the console: error

Someone else was playing about with it and mentioned that Discord was also saying interaction failed when trying to click buttons sometimes after applying this change, not sure if that'll help narrow anything down?

sebaxakerhtc commented 5 months ago

Unfortunately that's all that's shown in the console

What hardware do you have? As you can see on a screenshot above - there's no errors. I'm always using latest version of auto1111 (every start with git pull) RTX3090

JustGuyThatGuy commented 5 months ago

I've replicated the same issue on two different systems: 4060 Ti 16GB (Windows 11 via CUDA) RX 6800 XT (Ubuntu Desktop 22.04.4 via ROCm 6.0.2)

This was done on the latest master of Automatic1111 with just your change applied both times

sebaxakerhtc commented 5 months ago

I've replicated the same issue on two different systems

Did you edited files manually, or did you applied PR to the main branch?

JustGuyThatGuy commented 5 months ago

At first I'd manually applied the changes directly to master, but I also tried just cloning your fork and checking out the Live-preview branch, both did the same

sebaxakerhtc commented 5 months ago

At first I'd manually applied the changes directly to master, but I also tried just cloning your fork and checking out the Live-preview branch, both did the same

Dude... I can't reproduce that. There's no errors. Full log of installing and work of my branch "Live-preview" log.txt

JustGuyThatGuy commented 5 months ago

Not sure what to tell you, checked out your latest branch again and it's still doing it on both machines for me

sebaxakerhtc commented 4 months ago

After playing about with this a bit more, I've also noticed it's causing a bunch of Something goes wrong... 404 Not Found (error code: 10008): Unknown Message... not sure if it's somehow trying to interact with messages after they've been deleted perhaps?

I have to reproduce it on my son's PC with RTX3060 8GB VRAM (SDXL), because on SD1.5 no problems. Looks like it not responds few first seconds. So... For a slower cards the solution is to increase seconds for tries between requesting to access the progress here (line 28):

        if progress_data["current_image"] is None and tries <= 10:
            time.sleep(1)

For example like this:

        if progress_data["current_image"] is None and tries <= 10:
            time.sleep(3) # or even (5)
Kilvoctu commented 4 months ago

Heya, is this good to merge? I see some discussions back and forth

JustGuyThatGuy commented 4 months ago

Just checked out sebaxakerhtc's latest change with sleep(3) being used instead and haven't been able to replicate the issue I was having, so I think it should be good to merge now

sebaxakerhtc commented 4 months ago

Heya, is this good to merge? I see some discussions back and forth

Hi, @Kilvoctu! I think it depends on hardware, checkpoint, resolution, batch size, etc. Start time of Live preview may be variable. Errors are just output that there's no progress (IMHO) because with SDXL it starts later than on SD1.5 based checkpoints. That's why i just edited stablecog.py to increase pause from 1 to 3 seconds between tries of access to progress API. I havent these errors on my RTX 3090 as mentioned here

BTW, I found an issue at discord github page about this 10008 API error

But, yeah - it's awesome! To view progress and stop/skip it before it finishes the generation process and you will see unwanted result!

https://github.com/Kilvoctu/aiyabot/assets/32651506/db3a8944-ecbb-435d-b6fe-32e2ee95b53f

FoxxMD commented 4 months ago

Still need to address https://github.com/sebaxakerhtc/Marusya-bot-for-auto111/pull/11#issuecomment-1973768299

sebaxakerhtc commented 4 months ago

Still need to address sebaxakerhtc#11 (comment)

I think these errors was because of local changes Deleted and re-cloned Live-preview branch - there's no errors anymore even with queues Only this still happens in console:

Something goes wrong... 404 Not Found (error code: 10008): Unknown Message
sebaxakerhtc commented 4 months ago

Better implementation by the @FoxxMD in https://github.com/Kilvoctu/aiyabot/pull/253