search

KimNorgaard / validates_hostname

Extension to ActiveRecord::Base for validating hostnames and domain names
MIT License
38 stars 12 forks source link

gem? #1

Closed aaronchi closed 10 years ago

aaronchi commented 10 years ago

Would you consider pushing a gem to rubygems?

KimNorgaard commented 10 years ago

Aye - https://rubygems.org/gems/validates_hostname

aaronchi commented 10 years ago

thx!

aaronchi commented 10 years ago

Saw you are making changes to the gemspec. You should not make this dependent on v3 of Rails.

KimNorgaard commented 10 years ago

Care to elaborate on your view? I havn't tested it with rails-versions below 3, but if you can confirm that it works with other versions, then I won't mind removing the dependency.

aaronchi commented 10 years ago

I have been using it with Rails 3 and Rails 4 just fine. The way you have the gemfile configured now, it will only work with Rails 3.0.x, meaning it won't even run with Rails 3.2.

I would just drop the version requirement on Rails entirely as it seems to work fine. You can check some other validation gems for comparison.

KimNorgaard commented 10 years ago

Right, I removed the dependencies on specific versions and pushed 1.0.4.Thanks for the input.