search

KimNorgaard / validates_hostname

Extension to ActiveRecord::Base for validating hostnames and domain names
MIT License
38 stars 12 forks source link

Calling ActiveRecord::Base.send(:include, PAK::ValidatesHostname) has side effects #10

Open pgouv opened 6 years ago

pgouv commented 6 years ago

I was wondering why Rails.application.config.active_record.belongs_to_required_by_default was not working and this gem is the culprit. I am wondering whether there is a fix for this.

KimNorgaard commented 6 years ago

I have not been working with Rails for ages and currently do not have a lot of time on my hands. Any help fixing this issue would be much appreciated.

schwern commented 4 years ago

@KimNorgaard I'm interested in adopting this gem. I keep having the need to do domain validation in Rails and this is the best validator I've found.

Features I'd like to add:

KimNorgaard commented 4 years ago

Thank you for reaching out and offering help. I'm still a bit pressed on time but I'm willing to give you a commit bit and assist with pushing to rubygems when we have a stable version.

KimNorgaard commented 4 years ago

I just pushed v1.0.10 with the bugfix from #13 to rubygems. Since your changes are breaking backwards compatibility I'd like to move to wards v1.1.0 or possibly v2.0.0. What are your thoughts?

schwern commented 4 years ago

Thanks! I only have a couple years of Ruby experience, and this is my first time messing with a gem. I cribbed from another validation gem. I do have a lot of experience releasing Perl modules.

Yes, v2.0.0 makes sense if we're breaking backwards compatibility and following semantic versioning. If you have any other compatibility breaking changes you'd like to make while we're at it, perhaps you can write them up as issues and I can have a look.

KimNorgaard commented 4 years ago

My experience with releasing gems is also limited to this one, so I guess we are in the same boat. It's a pretty simple validator and I don't expect it to change much since it's pretty much based off the RFCs and they also don't change much. I don't have any big plans for a v2.

I once thought about doing something clever with the ALLOWED_TLDS list, specifically making it always updated, but the only way that would work would be fetching the list runtime which I'm against for obvious reasons. For now I've just updated it by hand periodically and bumped the version. I guess that suffices for most people.