Allow a config to update ALLOWED_TLDS

KimNorgaard / validates_hostname

Extension to ActiveRecord::Base for validating hostnames and domain names

MIT License

38 stars 12 forks source link

Allow a config to update ALLOWED_TLDS #18

Open kuahyeow opened 1 year ago

kuahyeow commented 1 year ago

Rather than updating the constant, and then waiting for a release, would it make sense to have a config option for gem users to configure the ALLOWED_TLDS ?

I guess users can update from http://data.iana.org/TLD/tlds-alpha-by-domain.txt, or customize as they require.

kuahyeow commented 1 year ago

Oh wait, there's already a valid_tlds option that is at the validator level. So maybe we don't need a global config after all.