search

Kimitsuna-Goblin / GGD

Gradational Gaussian Distribution
Other
0 stars 0 forks source link

Confusing kind and mix.type at [ggd.]trace.q #5

Closed Kimitsuna-Goblin closed 9 months ago

Kimitsuna-Goblin commented 9 months ago

Describe the bug Indicating mix.type should overwrite the kind argument, but ggd.trace.q(quantiles, kind="Vertical", mix.type=2) creates an object with a vertical gradation, not a horizontal gradation.

trace.q method occurs the same issue.

Expected behavior An object of a horizontal gradation should be created.

Desktop (please complete the following information):

Additional context ggd.nls.freq(data, kind="Vertical", mix.type=2) creates a horizontal gradation.

Kimitsuna-Goblin commented 9 months ago

I found bugs in the sources. In nls.freq (works well), it is checked whether this.mix.type argument is indicated or not at the point where "v3" or "v2" is set according to this.kind argument, but trace.q (not well) does not check it. However, in nls.freq, it was found that it made a redundant call to ggd.mix.type.for.kind.index function at the point. I will fix both of these issues.