Kimmax / Flash-dl

Flash(Youtube) Downloader using SYMM
GNU General Public License v2.0
0 stars 0 forks source link

Rebuild on top of ConsoleApplicationBase #3

Closed Kimmax closed 8 years ago

Kimmax commented 8 years ago

So here is what you asked for - I implemented your current work on top of the ConsoleApplicationBase. I'm sorry for the commit mess, I started by adding the ApplicationBase as a submodule -> implementing your work -> deleting the original project -> renaming the ApplicationBase Flash-dl -> merging into the repo -> fixing VS Files -> merge again. You should be able to merge this, however I would recommend moving this into a new branch, so your own working state is not affected if you decide not to use this fork, which is perfectly ok :+1:. Let me know if you need any Help!

Kimmax commented 8 years ago

Also note that I changed the .net framework back to 4.5 (I would recommend going even back further, but you're using something 4.5 newish), because 1) I hadn't 4.5.6 installed and 2) It's unnecessary, because you weren't using anything new which wouldn't be compatible with 4.5. Try to use the lowest possible framework, so you can push to most of the users, without them needing to install a new framework. Most of the developing can be done on 4.0, when not 3.5. Over and out :v:

ghost commented 8 years ago

Hey @Kimmax i will have a look at your pull request soon thank you so much man

ghost commented 8 years ago

@Kimmax can you push this to console-base... branch

ghost commented 8 years ago

Lol never mind i merged into master :)