Rubric and Summary - Githubissues

ulisigi commented 5 years ago

Rubric Score

Criteria 1: HTML and CSS Linking

Score Level: 4/4
Comment(s): HTML file contains a valid link to the correct CSS file.

Criteria 2: Implementation of Design Specification and Content

Score Level: 1/4
Comment(s): There are content or style omissions from the design specification in every section (header, brushes, frame, paint) of the page.

Criteria 3: HTML Elements and Content

Score Level: 3/4
Comment(s): Content: HTML content matches the design specification

Tags: The tags in the HTML are not used for their intended purpose (

for paragraphs, for headers, etc.) in one section.

Criteria 4: CSS Selectors and Syntax

Score Level: 4/4
Comment(s): Syntax: Uses proper selectors (id, class, element type). All rule sets are valid CSS

Overall Score: 12/16

Your project Meets Expectations - nice work! Overall, it appears that this project was made more complex than necessary. The reset.css stylesheet and the html5shiv.js are not introduced in the learning material before the project and therefore wouldn't be expected to be used to duplicate the design specification. Clearing the browser default styling with the reset stylesheet forced you to add additional styles like margins. We will begin to introduce the reset stylesheet in Unit 5 of the Intensive. Keep up the good work, and happy coding!

Kimoteo commented 5 years ago

Thank you ulisigi!

One question about Criteria 3. Besides the wrong use of the "strong" tag is there any other tag I am using incorrectly? You mention here "", but I don't find any errors with the "" tags when I compare my files to the ones of the exercise.

Another question regarding criteria 2. I changed the colors a bit on purpose to match better the colors on the pictures. Do we always need to deliver the exercises exactly as the specification or how much flexibility is it possible?

Best,

Karen

ulisigi commented 5 years ago

Hi Karen, The "" under Criteria 3 of the Rubric/Summary is an example and not indicative of incorrect usage in your project. Sorry about the confusing language there!

The colors that we see in the design specification are a bit desaturated. You'll see this again in future design specifications in the course. The color names on the design specification would have replicated the colors appropriately for your project, though they still would have appeared a little different on your screen because of the desaturation of the design specification.

For this project and Tea Cozy, the next to submit for review, you'll want to match the design specifications. If you want submit a project that intentionally deviates from the design specification, you'll want to include information about that in a README file, because reviewers will otherwise not be sure if deviations are intentional and we score based on adherence with a rubric like the one included above. It's generally best to submit Dasmoto and Tea Cozy aligned with the design specification, and maintain a separate copy unsubmitted if you want to experiment with different design ideas. The final project to submit, Colmar, does allow more flexibility in some of the design. Learners should adhere to the layout found in the redline document, but should choose their own color palette, CSS animations/transitions, and typography. There is a section of the rubric dedicated to these design decisions.

I hope this helps answers your questions. Happy coding!

Kimoteo / DasmotosArtsAndCrafts