search

Kimundi / owning-ref-rs

A library for creating references that carry their owner with them.
MIT License
362 stars 50 forks source link

Implement OwningRefMut #16

Closed bholley closed 7 years ago

bholley commented 8 years ago

I could be convinced there's a hazard here somewhere, but I have not been able to find a counter-example. This would be pretty helpful for some of the stuff we're doing in Servo, like [1].

[1] https://github.com/servo/servo/pull/13797

bholley commented 8 years ago

CC @SimonSapin

r? @Kimundi

SimonSapin commented 8 years ago

Looks good to me.

Kimundi commented 7 years ago

Hi, I'm sincerely sorry for taking so long to respond.

The code seems sound to me. I've reviewed and merged the code of both #10 and #16 and merged them into master. Thanks for the contribution!