search

Kimundi / owning-ref-rs

A library for creating references that carry their owner with them.
MIT License
359 stars 50 forks source link

Still maintained? #81

Open smessmer opened 2 years ago

smessmer commented 2 years ago

Is this still maintained? I see PRs with fixes going back to 2017 but nothing seems to get merged.

pinkforest commented 2 years ago

Hi @Kimundi @avitex @NikVolf

Would you be interested on handing over maintenance over or commit to fixing some soundness issues ?

The crate has ~ 12 M downloads as of today and it would be nice to fix these and keep it maintained

We are thinking of raising advisories here https://github.com/rustsec/advisory-db/issues/1174

The unsoundness has been documented here https://github.com/noamtashma/owning-ref-unsoundness

Soudness Issues https://github.com/Kimundi/owning-ref-rs/issues/49 https://github.com/Kimundi/owning-ref-rs/issues/61 https://github.com/Kimundi/owning-ref-rs/issues/71 https://github.com/Kimundi/owning-ref-rs/issues/77

utilForever commented 2 years ago

I created a repository that fixes some soundness issues. https://github.com/utilForever/owning-ref-rs

Ten0 commented 2 years ago

That would be really really useful considering how recurring this pattern is. Currently I refrain from using it because of the footguns implied by the unsoundness, but that would otherwise become a must!

Ten0 commented 2 years ago

I created a repository that fixes some soundness issues. https://github.com/utilForever/owning-ref-rs

With the history being entirely rewritten it's unclear what unsoundness issues are fixed/to what extent these differ from the open PRs.

pinkforest commented 2 years ago

prometheus-client addressed this by using parking_lot here: https://github.com/prometheus/client_rust/pull/78