Kin69 / EasyNotes

EasyNotes: Jetpack Compose MVVM for seamless note-taking. Effortless creation, editing, and organization.
GNU General Public License v3.0
333 stars 26 forks source link

Move cursor when selecting text formatting options #4

Closed Lenni-builder closed 4 months ago

Lenni-builder commented 4 months ago

Hi, this is a nice app in general, especially for such an early version, thanks for spending your time working on it!

The text formatting is a bit weird, in my opinion it should move the cursor next to the inserted characters (for titles and bullet points) or inbetween them (for quotes (?)).

For example: Where it currently puts the cursor: Screenshot_20240528-075003_Easy Notes

Where it should put the cursor: Screenshot_20240528-075022_Easy Notes

Where it currently puts the cursor: Screenshot_20240528-075036_Easy Notes

Where it should put the cursor: Screenshot_20240528-075111_Easy Notes

Where it currently puts the cursor: Screenshot_20240528-075124_Easy Notes

Where it should put the cursor: Screenshot_20240528-075145_Easy Notes

Kin69 commented 4 months ago

Hi there! Thanks for your kind words about the app. I'm glad you're finding it useful!

Regarding the text formatting issue you mentioned, it seems like there's a need to adjust the cursor positioning when inserting certain characters like titles, bullet points, or quotes.

To address this, I've made some adjustments to improve the cursor positioning. However, there's still an aspect that needs clarification: when inserting text on an empty line, should the inserted text be added to the same line or start on a new line?

Option A: Add inserted text to the same line if it's empty. Option B: Start a new line for the inserted text if the current line is empty.

Could you please let me know which option you think would work better for app? Thanks for your feedback!

For now, I implemented Option A. See https://github.com/Kin69/EasyNotes/commit/59a92fbaf68528963bf0a5e4fcb8b73088916d0d

Lenni-builder commented 4 months ago

I'd also prefer A, but if you select text, it would be nice if that was added next to the new #/bullet point or put in the code block.

Kin69 commented 4 months ago

Thanks for your input! I've needed to migrate to Option B for now due to bugs. I'll open a new feature request for the selected text functionality.