Kin69 / EasyNotes

EasyNotes: Jetpack Compose MVVM for seamless note-taking. Effortless creation, editing, and organization.
GNU General Public License v3.0
333 stars 26 forks source link

Wrong formatting of quotes #5

Closed Lenni-builder closed 4 months ago

Lenni-builder commented 4 months ago

In Markdown (which SimpleNotes seems to mostly use for formatting) 3 grave accents (```) are normally used to indicate code blocks, not quotes. Instead, you should use greater than signs (>).

Example:

``` This is a code block. ```

> This is a quotation. > This is a multi-line quotation.

derei commented 4 months ago

@Lenni-builder your experience seems strange... the app I installed uses the ``` for code blocks. Are you sure you are using Easy Notes, and not some other app? 😜

Lenni-builder commented 4 months ago

I'm sure it's EasyNotes ;)

The code block does neither have a monospace font nor does the icon to insert one look like one: Screenshot_20240528-100617_Easy Notes.png

Because of that I thought it should be used as a quote.

derei commented 4 months ago

@Lenni-builder yes, indeed it appears it doesn't use monospace font.

Then, your issue report would be better formulated to address the following aspects:

  1. Use monospace font in code blocks.
  2. Replace codeblock button icon by a more standardized symbol. Eg: github is using "<>".
  3. Replace the header icon (the TT, which generally means "text formatting options"), with a more standardized symbol. Github is using "H".
Lenni-builder commented 4 months ago

I first thought they were meant to be quotes, but since you clarified this this issue is kind of invalid. Your 3 points make sense.

Kin69 commented 4 months ago

Thank you for your feedback. I've made the requested changes to the code blocks, code block button icon, and header icon. I believe everything is now aligned with your suggestions.

Could you please confirm if the changes meet your expectations?

issue1 issue2

Lenni-builder commented 4 months ago

That looks great! It's also way less confusing now.