Able to add invalid address

[KinTatHo]

Information

Able to add negative values to streets, which should not be possible in real life

Steps to reproduce

1. add n/John p/98765432 e/johnd@example.com a/-1 Imaginary Road, Dream City, AA 12345 t/friends t/owesMoneyy

   Expected

   should not be able to add

   Actual

   person is added

[soc-se-bot]

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Thank you for pointing this out. However, under normal operations, the user would never enter a negative street number except when the user enters it by accident. If this were entered accidentally, the user can edit it and rectify it. As such, the severity should be low. Furthermore, we label this bug as not in scope as. The reason is that although it is possible to write a validator that allows for hypens to be in the address (which is crucial) while correctly identifying that in some cases the hypen is actually a negative sign and that value is part of a street number, it is much less important than the tasks of implementing other features that improves the software's functionality. Here's an example of why this validation is by no means trivial and is beyond the scope of this project. Consider the following address entries:

1. Imaginary Road -1, Dream City
2. Blk 03-1-3, Fantasy Condo

It is very challenging, and beyond the scope, to build a validator that accurately determines that the -1 in the first entry is a street name, and thus invalid, and the -1 in the second entry is the level entry of a condo address.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

• [ ] I disagree

Reason for disagreement: [replace this with your reason]

---

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]

---