search

KinTatHo / pe

0 stars 0 forks source link

Unable to add names with hypen #6

Open KinTatHo opened 2 months ago

KinTatHo commented 2 months ago

names like mary tan-goh are legit but can't be added

nus-se-bot commented 2 months ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Thank you for your feedback! Refer to #1313 which addresses the use of special characters.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unable to add names with special characters

image.png

Details:

  • Unable to add names containing special characters such as "Bashar al-Assad" or "Lebron James Jr."
  • This might prove inconvenient for users to add contacts with such names.

Suggestion:

  • Perhaps could relax the constraints to allow for greater range of accepted names.

[original: nus-cs2103-AY2324S2/pe-interim#1078] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank for your feedback. Unfortunately, we have to change the type of your bug since we were planning to address this in the planned enhancements, but the restrictions in the planned enhancements were too strict.

image.png

We should instead have said something like "Do not allow special characters inside any field..."

This is also a duplicate of issues 3835 and 5026

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]