search

Kinark / Materialize-stepper

A little plugin that implements a stepper to Materializecss framework.
https://kinark.github.io/Materialize-stepper/
MIT License
227 stars 60 forks source link

removeWrongOnInput doesn't track the changes in <select> just in <input> #85

Open imeckr opened 4 years ago

imeckr commented 4 years ago

The current implementation of removeWrongOnInput only listens to changes in <input> but not in <select>. I know the name is explicitly mentions inputs not select, but shouldn't that be the case as they are also kind of input? https://github.com/Kinark/Materialize-stepper/blob/be100c4414fe18c32d19c232613bbdd297d2966e/src/js/mstepper.js#L351

Kinark commented 4 years ago

Yep, it definitely should be listening for select changes as well. Gonna fix it ;)

Or you can help me by submitting a PR to the develop branch :D