KindDragon / vld

Visual Leak Detector for Visual C++ 2008-2015
https://kinddragon.github.io/vld/
GNU Lesser General Public License v2.1
1.01k stars 316 forks source link

Microsoft.Cpp.XXX.user.props Installation #14

Open ioannis-e opened 8 years ago

ioannis-e commented 8 years ago

I was wandering whether it is possible for the installer to use the following "better" way of installing VLD in Microsoft.Cpp.Win32.user.props and Microsoft.Cpp.x64.user.props instead of how its done now (commented below). These paths are global and using Additional...Directories which are per project/configuration pollutes the entry.

<?xml version="1.0" encoding="utf-8"?>
<Project DefaultTargets="Build" ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
  <PropertyGroup Label="UserMacros">
    <VLD_INCLUDE>C:\Program Files (x86)\Visual Leak Detector\include</VLD_INCLUDE>
    <VLD_SRC>C:\Program Files (x86)\Visual Leak Detector\src</VLD_SRC>
    <VLD_LIB_x86>C:\Program Files (x86)\Visual Leak Detector\lib\Win32</VLD_LIB_x86>
    <VLD_LIB_x64>C:\Program Files (x86)\Visual Leak Detector\lib\Win64</VLD_LIB_x64>
  </PropertyGroup>
  <PropertyGroup>
    <IncludePath>$(VLD_INCLUDE);$(IncludePath)</IncludePath>
    <LibraryPath>$(VLD_LIB_x86);$(LibraryPath)</LibraryPath>
    <SourcePath>$(VLD_SRC);$(SourcePath)</SourcePath>
  </PropertyGroup>
  <ItemGroup>
    <BuildMacro Include="VLD_INCLUDE"><Value>$(VLD_INCLUDE)</Value><EnvironmentVariable>true</EnvironmentVariable></BuildMacro>
    <BuildMacro Include="VLD_SRC"><Value>$(VLD_SRC)</Value><EnvironmentVariable>true</EnvironmentVariable></BuildMacro>
    <BuildMacro Include="VLD_LIB_x86"><Value>$(VLD_LIB_x86)</Value><EnvironmentVariable>true</EnvironmentVariable></BuildMacro>
    <BuildMacro Include="VLD_LIB_x64"><Value>$(VLD_LIB_x64)</Value><EnvironmentVariable>true</EnvironmentVariable></BuildMacro>
  </ItemGroup>
<!--
  <ItemDefinitionGroup>
    <ClCompile>
      <AdditionalIncludeDirectories>C:\Program Files (x86)\Visual Leak Detector\include;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
    </ClCompile>
    <Link>
      <AdditionalLibraryDirectories>C:\Program Files (x86)\Visual Leak Detector\lib\Win32;%(AdditionalLibraryDirectories)</AdditionalLibraryDirectories>
    </Link>
    <Lib>
      <AdditionalLibraryDirectories>C:\Program Files (x86)\Visual Leak Detector\lib\Win32;%(AdditionalLibraryDirectories)</AdditionalLibraryDirectories>
    </Lib>
  </ItemDefinitionGroup>
-->
</Project>
KindDragon commented 8 years ago

We can do that way, but we need properly update already patched file.