search

KindDragon / vld

Visual Leak Detector for Visual C++ 2008-2015
https://kinddragon.github.io/vld/
GNU Lesser General Public License v2.1
1.01k stars 316 forks source link

rebased ioannise PR #7

Closed Trass3r closed 8 years ago

Trass3r commented 8 years ago

https://vld.codeplex.com/SourceControl/network/forks/ioannise/vld/contribution/8453 rebased it to current master to fix https://vld.codeplex.com/workitem/9519

Otherwise it's impossible to use vld with Qt or any other framework using file open dialogs. Tested with VS2015 x64 on Windows 7.

KindDragon commented 8 years ago

Sorry. Can't accept it. Almost all test dosn't work

Trass3r commented 8 years ago

Question is why. I don't see compilation errors, only "Build execution time has reached the maximum allowed time for your plan (40 minutes)." hidden in the messages tab and some "The system cannot find the path specified" https://ci.appveyor.com/project/KindDragon/vld/build/61/job/9oo19keut0dlbihk/messages

ioannis-e commented 8 years ago

@Trass3r and @KindDragon, I have updated today my fork and PR on codeplex (PR shows more commits for some reason).

I would suggest to use the latest version as i cleaned up some code and fixed some bugs in my code. I tested my latest work on VS2013 and 2015 fully with all tests PASSING VS2010 had some issues compiling debug versions regarding _ITERATOR_DEBUG_LEVEL

The way the tests were run were to "Batch Build..." everything, then run the following

runalltests.bat v120

or

runalltests.bat v140

@KindDragon if you are interested we can discuss the commits here, on codeplex or on irc in order to identify what you like and don't like and cherry pick as much as possible into the master, in order to resolve some long standing issues.

EDIT: i forked the repo on github as well as i find it easier to work with.

ioannis-e commented 8 years ago

I am running appveyor now and i realised i changed the configuration name in vs14 (to be consistent accross VS versions) which causes build failure.

I will revert that change by force push and run appveyor again.

Trass3r commented 8 years ago

@ioannis-e even better! Hope it will be upstream soon.

ioannis-e commented 8 years ago

Appveyor Success Now we need to review and discuss any performance optimazations

KindDragon commented 8 years ago

@ioannis-e please create PR on GitHub to discuss further and check Appveyor status