search

Kindling / react-tinymce-mention

@Mentions functionality for TinyMCE, built with React and Redux
MIT License
20 stars 15 forks source link

Components of this library must extend React.Component #3

Closed RaitoBezarius closed 8 years ago

RaitoBezarius commented 8 years ago

It seems like that the Mention component which is exported does not inherit from React.Component, and neither is a React old-style class.

Is there any reason for this? Same goes for SuggestionRenderer and DefaultList.

Furthermore, in React 0.14, you don't need to wrap <Provider> child into a function.

TuningGuide commented 8 years ago

I really would like to use this Component but I'm unable to use it because React (15.3.x) complains about "Uncaught TypeError: Cannot call a class as a function". Could you fix this or tell me how to build the source myself?

damassi commented 8 years ago

@TuningGuide and @RaitoBezarius - Hi, i'm pretty far removed from this work at this point (previous employer) but feel free to fork and submit a PR and I'll review / merge. See https://github.com/Kindling/react-tinymce-mention#development for development instructions.

damassi commented 8 years ago

Fixed in https://github.com/Kindling/react-tinymce-mention/pull/4