search

Kinds-of-Intelligence-CFI / animal-ai-unity

Animal-AI Unity
https://github.com/Kinds-of-Intelligence-CFI/animal-ai
Apache License 2.0
2 stars 2 forks source link

Issue spawning items in the E2E tests #43

Open benaslater opened 23 hours ago

benaslater commented 23 hours ago

Describe the Bug While updating the mlagents version E2E screenshot tests, I noticed the expected screenshots look a bit suspicious for some items. Bad Goal Multi and Hollow Box were absent and Ripen Goal and Shrink Goal were half submerged in the arena. We should investigate and make sure these items are working properly (and see if we can fail more loudly next time something like this goes wrong)

To Reproduce Examine current version of screenshot E2E tests screenshots for:

Expected Behavior For the first two, an item should be visible in the screenshot. For the second two the object should not be submerged in the arena (would be better to throw)

Desktop (please complete the following information):

Screenshots Expected_HollowBox Expected_HollowBox Expected_RipenGoal Expected_ShrinkGoal

benaslater commented 22 hours ago

It when I updated my unity to the latest version it seems the Bad Goal Multi works now, so an intervening change has fixed that (perhaps https://github.com/Kinds-of-Intelligence-CFI/animal-ai-unity/commit/058c71de2e752b67db75f21abadc0c3717fa7d55)

alhasacademy96 commented 22 hours ago

These first two objects were newly added to the list of acceptable objects (hollow box was meant to be added in 4.1.0 but I forgot to add it then) badgoalmulti is new for 4.2.0 completely. Your recent comment is correct to assume that badgoalmulti works for the referenced commit (and being added to list of acceptable objects). I'm not sure why the other objects are behaving erratically.