KinesisCorporation / Adv360-Pro-GUI

Keymap Editor for the Advantage360 Pro with ZMK
Apache License 2.0
23 stars 52 forks source link

Fails to load my custom keymap in a different branch #14

Open douglascamata opened 6 months ago

douglascamata commented 6 months ago

What's the issue?

Using a different web configurator available at https://nickcoutsos.github.io/keymap-editor/, I can properly see my custom config from my fork's V3.0-custom branch (see picture below). Notice how I use the 1st row of keys for the symbols (!@#$% and so on) instead of the numbers.

image

Meanwhile, using Kinesis' GUI, you might notice by the 1st row there that my keymap isn't being loaded (see picture below). In the 1st row the numbers are appearing.

image

What I think is happening

Your API hosted at https://adv360-pro-api.herokuapp.com is returning the wrong layout for my custom branch.

I see through the browser's console that the request is sent to this API: https://adv360-pro-api.herokuapp.com/github/keyboard-files/<SOME_ID_THAT_I_WANT_TO_HIDE>/douglascamata%2FAdv360-Pro-ZMK?branch=V3.0-custom.

But in the response the layout that is returned is not from my V3.0-custom branch.

douglascamata commented 6 months ago

It seems like for some reason Kinesis' web UI is parsing the keymap.json file instead of the adv360.keymap one. As I started customizing my layout very early through https://nickcoutsos.github.io/keymap-editor/ (which parses the adv360.keymap file), before Kinesis offered its GUI, my keymap.json file is completely out of sync.

ReFil commented 5 months ago

The best solution is to stick to using one editor or the other. Nick's editor is compatible with the 360 Pro config repo, but changes made on his editoe will not be reflected in the kinesis editor

douglascamata commented 5 months ago

Wouldn't it be better if there was some compatibility between the editors? IMHO, Nick's doing the right thing by parsing the .keymap file and Kinesis added the json file as their our custom thing. From a user point of view, I see no advantage in using the json file -- in fact it only limits me to only be able to use Kinesis' made tools otherwise things go out of sync like this.