CI & command-line build

jrr commented 4 years ago

This PR configures CI via GitHub Actions.

Highlights

Every push and PR will trigger a build of all four apps on three platforms (Mac 64 / Windows 32 / Linux 64)
Artifacts are saved so you can download the latest binaries (Example green build)
The Makefile can be used for command-line builds (e.g. make smartset_fsedge), and it handles dependencies when lazbuild doesn't.

It took only a few small code changes to get Linux builds going. (SmartSetSavantElite/u_form_keypress.pas and both u_const.pas files)
I wound up setting a --widgetset for Windows in order to avoid errors related to LCL and cocoa.
Of the binaries the build produces, the only combination I've tested is Edge/Pro on Mac since that's what I have readily available. For what it's worth, the Mac app appears to work: it's able to see and write settings on both my Edge and my Pro.

I hope this is useful for the project and for supporting further community contributions.

I'm new to Pascal and Lazarus and would welcome feedback on anything I've done here.

vadlamak commented 4 years ago

@jrr this is great, i hope @KinesisCorporation reviews this pr soon

jrr commented 3 years ago

Because it's mildly interesting I continue to periodically try to keep this PR alive.

I rebased against the latest changes, and:

I disabled the CI builds of Adv2, FSEdgePro and RGB, which worked before but are now broken. SavantElite still builds!
- (for anyone interested, here's an old branch where they all still build)
I haven't looked in to the new SmartSetMaster or TKO apps yet, but hopefully they'll be command-line buildable if they're the future of this repo.

jrr commented 3 years ago

Got the master app building in CI, and the resulting binary works on my machine (on MacOS Big Sur):

jrr commented 3 years ago

Got the RGB build going again. TKO is currently broken.

jrr commented 3 years ago

After rebasing against the latest commits on master, all four current apps are successfully building! (Advantage, Master, FSEdge, and Savant Elite)

So, @KinesisCorporation this would be a great time to merge the PR ;)

Are you interested at all in continuous integration?

With every push, GitHub will build the apps on each platform.
It's a great way to keep track of when your changes inadvertently break another app or another platform.
Eventually, if you adopt a practice of using pull requests, you could set a policy so that pull requests require passing builds before they can be merged.
Who knows, maybe one day there could even be unit tests!

And you could have one of these badges like all the cool kids these days:

ghost commented 3 years ago

This is great. It's unfortunate the PR still hasn't been merged/reviewed.

jrr commented 2 years ago

Rebased again. Currently building only SmartSetMaster and the new SmartSetMasterOffice; the other apps have errors.

jrr commented 2 years ago

Rebased again with a couple updates:

now building SmartSetMaster, SmartSetMasterOffice, SmartSetTKO, and SmartSetRGB
manually installing Lazarus for the Mac build (instead of using homebrew's older version)

Findarato commented 8 months ago

Are these even looked at any more?