search

Kinetic / kinetic-protocol

34 stars 21 forks source link

Unsolicited Suggestion #20

Open garyballance opened 10 years ago

garyballance commented 10 years ago

The “Unsolicited Status” message has no message type but instead is identified by an authentication type of “Unsolicited Status”. It would be nice if all messages had a message type given that the Kinetic device reports message statistics based on message type (which would prevent stats for those messages from being reported). Also, “Unsolicited Status” seems to describe a type of message more than a type of authentication. If possible, I’d suggest changing its message type to “Unsolicited Status” and its authentication type to “None” (which also seems like the appropriate authentication type to specify for responses to requests that use PIN authentication).

Thanks.

jphughes commented 10 years ago

These are good suggestions. Please give me a few days to create a response.

Jim

On Sep 27, 2014, at 12:08 AM, Gary Ballance notifications@github.com wrote:

The “Unsolicited Status” message has no message type but instead is identified by an authentication type of “Unsolicited Status”. It would be nice if all messages had a message type given that the Kinetic device reports message statistics based on message type (which would prevent stats for those messages from being reported). Also, “Unsolicited Status” seems to describe a type of message more than a type of authentication. If possible, I’d suggest changing its message type to “Unsolicited Status” and its authentication type to “None” (which also seems like the appropriate authentication type to specify for responses to requests that use PIN authentication).

Thanks.

— Reply to this email directly or view it on GitHub https://github.com/Seagate/kinetic-protocol/issues/20.

jphughes commented 9 years ago

We are working through this change. Very straight forward. Thanks. Should be a day or so until we get the .proto updates. This change should be compatible with pre-change .proto.

On Sep 27, 2014, at 12:45 AM, James Hughes jphughes@mac.com wrote:

These are good suggestions. Please give me a few days to create a response.

Jim

On Sep 27, 2014, at 12:08 AM, Gary Ballance <notifications@github.com mailto:notifications@github.com> wrote:

The “Unsolicited Status” message has no message type but instead is identified by an authentication type of “Unsolicited Status”. It would be nice if all messages had a message type given that the Kinetic device reports message statistics based on message type (which would prevent stats for those messages from being reported). Also, “Unsolicited Status” seems to describe a type of message more than a type of authentication. If possible, I’d suggest changing its message type to “Unsolicited Status” and its authentication type to “None” (which also seems like the appropriate authentication type to specify for responses to requests that use PIN authentication).

Thanks.

— Reply to this email directly or view it on GitHub https://github.com/Seagate/kinetic-protocol/issues/20.

garyballance commented 9 years ago

That's great. Thanks.