search

Kinetic / kinetic-protocol

34 stars 21 forks source link

max keys returned in getkeyrange #32

Open pareshpp opened 9 years ago

pareshpp commented 9 years ago

Does the protocol set any limit on max keys returned by server in getkeyrange() operation?

jphughes commented 9 years ago

Yes, the limit is 200 keys. The choice of 200 keys was that with 4k keys, the returned protobuf will be <1MByte.

On Aug 31, 2015, at 4:48 AM, pareshpp notifications@github.com wrote:

Does the protocol set any limit on max keys returned by server in getkeyrange() operation?

— Reply to this email directly or view it on GitHub https://github.com/Seagate/kinetic-protocol/issues/32.

pareshpp commented 9 years ago

What if the protobuf size is > 1MB?Let's say if it is 2MB, can the getKeyrange() return 200*2 keys?

jphughes commented 9 years ago

The recommendation is to keep the protobuf below 1MB. When you have max length keys (4096), 400 keys is 800kB. We choose 200 because it was round number mostly filling the protobuf.

On Sep 3, 2015, at 10:00 AM, pareshpp notifications@github.com wrote:

What if the protobuf size is > 1MB?Let's say if it is 2MB, can the getKeyrange() return 200*2 keys?

— Reply to this email directly or view it on GitHub https://github.com/Seagate/kinetic-protocol/issues/32#issuecomment-137511670.