Closed rpcope1 closed 10 years ago
@rpcope1 the operation returns None because there is nothing to be returned from a firmware update. It either succeeds or it fails. Failures are raised as exceptions. Some failures might have their subclass with extra information. The only exception to raising exceptions on failed operations is the status _NOTFOUND, which can be returned on gets. Usually this operation will return what was asked for, or None if not found, or blow up if something else is returned. For everything else, we raise an exception when the status code is other than SUCCESS.
Nacho, previously on updateFirmware() we returned true if a fault wasn't raised in the process. The Kinetic protocol returns a status code when a setup command is processed, which will return SUCCESS if the command was ok. It would be cool if on the process method for setup that we returned True if SUCCESS was the returned status code and False otherwise, instead of just returning None as the AdminClient does today.