search

Kinetic / kinetic-py

Kinetic Python Library
http://seagate.github.io/kinetic-py
22 stars 10 forks source link

Update operations.py #16

Closed rpcope1 closed 10 years ago

rpcope1 commented 10 years ago

Removed the error handling on GetLog for NOT_FOUND (return None on NOT_FOUND), as I don't think you expect this to normally occur the same way it would for a regular get (i.e. it may be intuitive for get to return None if no associated key was found, but it isn't quite as intuitive for the getLog command to return None if the drive faults on getting a log and returns not found).

This should partially address issue #15. This is also partially a drive issue.

icorderi commented 10 years ago

This is not correct @rpcope1, Returning None for Not found is semantically correct. The issue is that all the get logs are returned, but the device log was not found, mainly because it was not specified. Lets continue this on #15