search

Kinetic / kinetic-py

Kinetic Python Library
http://seagate.github.io/kinetic-py
22 stars 10 forks source link

Baseclient.py line 109 uses socket defaults #8

Closed markw- closed 10 years ago

markw- commented 10 years ago

Hi,

In baseclient.py the line calling socket.socket() has no args which means the new socket will use the socket defaults which inlcude AF_INET as the address family and it should be AFINET6. Then a kinetic client request will work on something other than localhost.

I reported this in the old closed source kinetic client, but as it was closed source all I could say was that making a connection to something other than localhost didn't work and it looked like the call was making a gethostbyname instead of getaddrinfo.

Now I have found out why it failed, line 109 should be changed to "return socket.socket(socket.AF_INET6)".

Cheers Mark

icorderi commented 10 years ago

@markw- , that change would make the clients work on ipv6 only

I just added IPv6 support on all clients based on the address provided. It's on the develop branch now.

markw- commented 10 years ago

I must have missed the email thanking me for taking a look at this bug ;-) I've only just started to look at the code now it's open source, so it will take me some time before I've found my way though it (I have a day job :-))

Cheers Mark

On 2014-06-30 23:32, Ignacio Corderi wrote:

@markw- [1] , that change would make the clients work on ipv6 ONLY

I just added IPv6 support on all clients based on the address provided. It's on the develop branch now.

Reply to this email directly or view it on GitHub [2].

Links:

[1] https://github.com/markw- [2] https://github.com/Seagate/kinetic-py/issues/8#issuecomment-47590059

jphughes commented 10 years ago

Hi Mark:

Thanks for the great help! Ignacio can be a bit curse at times. Did you get to see what he did in the develop branch? Did it work for you?

Sincerely

Jim

markw- commented 10 years ago

Hi Jim,

Thanks for the reply - yep, develop is working with IPv6 so I'm going to start to build some test configurations and have some fun.

Cheers!

Mark

On 2014-07-01 05:03, James Hughes wrote:

Hi Mark:

Thanks for the great help! Ignacio can be a bit curse at times. Did you get to see what he did in the develop branch? Did it work for you?

Sincerely

Jim

Reply to this email directly or view it on GitHub [1].

Links:

[1] https://github.com/Seagate/kinetic-py/issues/8#issuecomment-47612272