search

KineticPreProcessor / KPP

The KPP kinetic preprocessor is a software tool that assists the computer simulation of chemical kinetic systems
GNU General Public License v3.0
22 stars 11 forks source link

[BUG/ISSUE] Rosenbrock.f90 Case (-7) #113

Closed Fu-Weitao closed 2 months ago

Fu-Weitao commented 2 months ago

Report a bug or issue with KPP:

In Rosenbrock.f90, Line 553, it has the following expression "T+0.1_dpH". However, in Line 436, it show "T+ 10H". It looks like a typo to me. If it is, should it be 10 or 0.1? Thank you!

RolfSander commented 2 months ago

I can find 0.1 H in line 553 but I cannot see 10 H in line 436 in my file rosenbrock.f90. Maybe your file is different? Can you post the file that has the factor 10 in line 436?

Fu-Weitao commented 2 months ago

Hi Rolf,

Thank you for your reply. I mean Line 463, not 436. Sorry about that. The error message seems to be incorrect.

Weitao Fu

On Sep 4, 2024, at 7:33 PM, Rolf Sander @.***> wrote:



I can find 0.1 H in line 553 but I cannot see 10 H in line 436 in my file rosenbrock.f90. Maybe your file is different? Can you post the file that has the factor 10 in line 436?

— Reply to this email directly, view it on GitHubhttps://github.com/KineticPreProcessor/KPP/issues/113#issuecomment-2328697971, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANXQYJLESRAK7OKPUGSIGVTZU3VZNAVCNFSM6AAAAABNUAFCNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRYGY4TOOJXGE. You are receiving this because you authored the thread.Message ID: @.***>

RolfSander commented 2 months ago

Ah, I found it.

The code uses 0.1*H, and this is correct. The printed error message is wrong.

Thanks for the bug report, I've corrected the error message.