search

KineticPreProcessor / KPP

The KPP kinetic preprocessor is a software tool that assists the computer simulation of chemical kinetic systems
GNU General Public License v3.0
21 stars 11 forks source link

Cleanup of unused features #19

Closed yantosca closed 2 years ago

yantosca commented 2 years ago

@RolfSander has opened the cleanup branch, which removes several unused/obsolete files. We will test to make sure that none of the existing functionality is clobbered.

RolfSander commented 2 years ago

Thanks! I hope all the ci-tests are still working. The only change I made is that small_f90 now uses int/kpp_lsode.* instead of int.modified_WCOPY/kpp_lsode.*.

yantosca commented 2 years ago

I just verified that all the CI-tests work properly in the cleanup branch. See: ci-tests-log.txt

RolfSander commented 2 years ago

I'm not sure if my comment in the pull request was visible, since it is closed now. So I'm repeating it here:

I have a couple of other cleanup-items which I want to do next. I'll create a new "cleanup2" branch for that. One thing I noticed is that we have a .gitignore file in almost every directory. That's not necessary because a .gitignore file in the root directory affects all subdirectories automatically.

One more minor comment on .gitignore: Some of the files contain the line #* which probably should ignore files starting with a hash. However, this doesn't work because lines starting with # are comments in .gitinore. We need to write \#* instead, see:

https://stackoverflow.com/questions/2209810/add-glob-to-gitignore

RolfSander commented 2 years ago

already merged into dev