search

KineticPreProcessor / KPP

The KPP kinetic preprocessor is a software tool that assists the computer simulation of chemical kinetic systems
GNU General Public License v3.0
21 stars 11 forks source link

Where to add new solvers #37

Closed msl3v closed 2 years ago

msl3v commented 2 years ago

@yantosca @RolfSander @laestrada I'm going to add a forward Euler solver. Should it go into int/user_contributed/ or just stay in int/? @RolfSander I see your ros2_manual.f90 in int/user_contributed/

RolfSander commented 2 years ago

I'd say we put all integrators which are maintained and supported by us into int/. The directory int/user_contributed/ can be used for all others.

RolfSander commented 2 years ago

We now have 2 Euler integrators. Should we try a consistent naming? Maybe:

forward_euler.f90 and backward_euler.f90

or:

feuler.f90 and beuler.f90

RolfSander commented 2 years ago

Are you going to add a *.def file as well?

msl3v commented 2 years ago

I only just now saw the beuler.f90 solver (I assumed Beuler was the name :-) ) . Yeah. I'll change the name to feuler.f90 This was just an initial commit. I'll add the def file etc soon.

RolfSander commented 2 years ago

I just noticed that several of the *.def files contain F77 INLINE code even though there is no corresponding integrator in F77 syntax. I think this can be deleted in these files:

beuler.def
rosenbrock_adj.def
rosenbrock_mz.def
rosenbrock_posdef.def
rosenbrock_posdef_h211b_qssa.def
rosenbrock_split.def
rosenbrock_tlm.def
sdirk_adj.def
sdirk_tlm.def
yantosca commented 2 years ago

We can close this issue since #38 has now been merged into dev.