search

KineticPreProcessor / KPP

The KPP kinetic preprocessor is a software tool that assists the computer simulation of chemical kinetic systems
GNU General Public License v3.0
21 stars 11 forks source link

Cleanup in auto-reduce code and add CI tests #49

Closed jimmielin closed 2 years ago

jimmielin commented 2 years ago

This PR replaces REAL(kind=dp) in rosenbrock_autoreduce with KPP_REAL for consistency with other integrators.

I also added a new driver general_autoreduce and added a CI test ros_autoreduce which uses the auto-reduction integrator. Interestingly, it runs slower than the regular ros for some reason. The test is only to make sure the integrator isn't broken in future releases - tests of the AR integrator for science should still use the box model developed by @msl3v here https://github.com/KineticPreProcessor/KPP-AR-boxmodel

RolfSander commented 2 years ago

looks good

jimmielin commented 2 years ago

Thanks @RolfSander I'll go ahead and merge this!