Closed jimmielin closed 2 years ago
One more thing: When we're done with Vdotout, we should check if this affects the Matlab code as well (one of the matlab fixes that I recently applied was related to Vdotout).
Also, GEOS-Chem 14.0.0 will use KPP 2.5.0. So we could bring this in now, and I can fix fullchem_mod.F90
in GEOS-Chem for a future version.
One more thing: When we're done with Vdotout, we should check if this affects the Matlab code as well (one of the matlab fixes that I recently applied was related to Vdotout).
Hi @RolfSander, I just checked the Matlab fix:
It looks like support for Vdotout
was added in MATLAB in this commit. I simply removed this feature for MATLAB, replacing
if( z_useAggregate )
MATLAB_Inline("\n Vdotout = Vdot(:);\n");
else
MATLAB_Inline("\n P_VAR = P_VAR(:);\n D_VAR = D_VAR(:);\n");
with
if( !z_useAggregate )
MATLAB_Inline("\n P_VAR = P_VAR(:);\n D_VAR = D_VAR(:);\n");
Does this look good? We should probably have some CI-tests for Matlab in the future, maybe using GNU Octave. Maybe it will run with Octave, maybe not, I can give it a try.
I'll update the wrong note I added in the documentation shortly.
I'm not sure if Vdotout
was really needed in Matlab. I think I'll just ask our Matlab colleagues.
It would be nice if the Matlab code runs in Octave...
As discussed in #50,
Vdotout
can be obsoleted and replaced withVdot
inFun()
.This update requires accompanying updates on the GEOS-Chem side, namely replacing
Vdotout
byVloc
here.We probably don't have to merge this into 3.0.0 right away if there is no time / there is a code freeze for GEOS-Chem 14. But it should be a relatively minor change to make.