search

KineticPreProcessor / KPP

The KPP kinetic preprocessor is a software tool that assists the computer simulation of chemical kinetic systems
GNU General Public License v3.0
19 stars 11 forks source link

FIX must be the 2nd argument passed to FUN in int/feuler.f90 (plus doc updates) #61

Closed yantosca closed 1 year ago

yantosca commented 1 year ago

This is the corresponding PR to #60. Also, documentation has been updated to denote this will be KPP 3.0.0-rc.4.

Closes #60

RolfSander commented 1 year ago

AFAICS, this is fine. However, maybe Mike also wants to comment, as feuler.f90 is his code?

yantosca commented 1 year ago

@msl3v, do you have any comments about this?

msl3v commented 1 year ago

This fix is correct. VAR was included erroneously as an argument to FUN() in feuler.f90.

yantosca commented 1 year ago

@msl3v @jimmielin @RolfSander: could one of you approve the PR? I can't do it as the author. Then I can merge & release. Thanks!

yantosca commented 1 year ago

Also note: GitHub allows you to automatically generate release notes based on the comments in the logs from each PR. So it's important that even simple fixes like this go thru a PR.

jimmielin commented 1 year ago

Thanks Bob, approved!

msl3v commented 1 year ago

Wasn't listed as a reviewer. Could I still have approved this? (I looked but didn't see that it was possible)

yantosca commented 1 year ago

My bad, @msl3v. I should have made you a reviewer.