Closed yantosca closed 7 months ago
Maybe we need to tell the user that with this solution, the constants_mcm.f90 file may have USE mcm_Precision, USE mcm_Parameters and USE mcm_Global, but no other USE ... commands. If a user adds additional dependencies, they will have to adjust the Makefile.
Thanks @RolfSander. I can update the README.md file accordingly.
Although it is good to allow users to use upper-case suffixes, I'm a bit worried about backward compatibility. The command #UPPERCASEF90 did not exist before KPP 2.5.0. Of course, here in the git repo it is fine to have the new command. However, when we offer the MCM developers a minimal working example, I'd prefer a mcm.kpp file without #UPPERCASEF90. I think that most MCM users still haven't upgraded to KPP >= 2.5.0.
Duly noted.
Overview
This PR does the following:
Adds a C-I test for the MCM minimal example to the existing C-I scripts.
Updates the
util/Makefile_f90
andutil/Makefile_upper_F90
to allow the user to pass an environment variable (EXTERNAL_RATES_F90
) to specify an external module to be USE-d viaF90_RCONST
Adds
#UPPERCASEF90
to theexamples/mcm/mcm.kpp
file to allow the user to let KPP build source code with either.f90
or.F90
suffixes. Default is#UPPERCASEF90 OFF
.Removed the
examples/mcm/Makefile
; we can now let KPP build the Makefile.Migrated
examples/mcm/README
->/examples/mcm/README.md
(with Markdown)See issue #4
Output
Complete log file from C-I test: