KineticPreProcessor / KPP

The KPP kinetic preprocessor is a software tool that assists the computer simulation of chemical kinetic systems
GNU General Public License v3.0
19 stars 11 forks source link

Remove obsolete #TRANSPORT and #TRANSPORTALL commands #87

Closed yantosca closed 7 months ago

yantosca commented 7 months ago

Overview

This PR removes the obsolete #TRANSPORT and #TRANSPORTALL commands from KPP. These are very old commands and probably have not worked in a very long time.

See issue #86 for context.

Modifications

RolfSander commented 7 months ago

Thanks, @yantosca for removing the obsolete #TRANSPORT from KPP!

I've made a few more changes. Could you check if you agree?

RolfSander commented 7 months ago

A related question: Should we also remove #LUMP? I think it is also obsolete.

yantosca commented 7 months ago

Hi @RolfSander, yes, thanks for also removing the other trans variables in the C code. I think that's fine.

I can go ahead and also remove #LUMP as well. I can make that a separate PR.