KingContaria / FastQuit

Lets you return to the title screen early while your world is still saving in the background
MIT License
50 stars 18 forks source link

Slight Incompatibility with Sword Blocking Mechanics #45

Open TheBiggestHuman opened 5 months ago

TheBiggestHuman commented 5 months ago

Using v8.0.1 for Minecraft v1.20.1 of Sword Blocking Mechanics and using v3.0.0 of FastQuit: FastQuit seems to do something that resets the config file of Sword Blocking Mechanics.

Basically, With both mods installed, they work as expected upon loading the world once, but exiting once and loading into the world again results in the config being reset to the default configuration. No other mods seem to be affected. With only Sword Blocking Mechanics installed, everything works as expected.

The same happens in a brand new install of Minecraft with the latest version of Fabric (0.15.11)

KingContaria commented 5 months ago

Thanks for the reproduction steps!

Unfortunately I wasn't able to reproduce using the following set of mods on a fresh instance of Minecraft:

I created a new world, went into Mod Menu to configure Sword Blocking Mechanics, set "Full Interact Animations" and "Render Parry Indicator" to OFF in swordblockingmechanics-client.toml and Allow Blocking to OFF in swordblockingmechanics-server.toml, then quit the world and rejoined it immediately once it finished saving. Upon rejoining, my configured options remained.

If you are using more mods than this I would appreciate if you could try to narrow down the modset. A log file of a session with this bug happening would also be very helpful!

Thanks :)

TheBiggestHuman commented 5 months ago

Thank you for the response!

I have tested using the same method you have and still found the issue. I have noticed though that any changes through the Forge Config Screens mod does not affect anything for me, I presume due to the default settings of Forge Config API Port which prevent per-world configuration files. So I have been altering the swordblockingmechanics-server.toml file directly in the config folder and it is the one being reset, the client config file works perfectly fine. Sorry for not making that bit clear!

Also I am attaching the log, the only bit I found of interest is when it says all the values are null in the config on loading. latest.log

KingContaria commented 5 months ago

That's interesting, the config libraries I know and use don't permit editing the file directly while in game, I'll give that a try later, thanks!